chore: Make FontAwesome CDN URL configurable via environment variable - #424
chore: Make FontAwesome CDN URL configurable via environment variable#424Strehk wants to merge 2 commits into
Conversation
The FontAwesome CDN location changed again. Introduce a required PUBLIC_FONTAWESOME_CSS_BASE_URL environment variable so the CSS base URL can be configured in production instead of being hard-coded in app.html. The stylesheet links now use a %fontawesome.baseUrl% placeholder that is substituted in the server hook. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T4QrtB6cFFZPx8VnAuiK4F
|
Warning Review limit reached
Next review available in: 55 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Strehk
changed the title
Trivy flagged nodemailer 7.0.13 with GHSA-p6gq-j5cr-w38f (HIGH): the message-level raw option bypasses disableFileAccess/disableUrlAccess. The vulnerability is not reachable in this codebase (emailService only sends from/to/subject/html/text/replyTo, never raw or attachments), but upgrading to 9.0.3 removes the finding at the source and unblocks the security CI check. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T4QrtB6cFFZPx8VnAuiK4F
m1212e
left a comment
m1212e
left a comment
There was a problem hiding this comment.
Do we have a reasonable default?
3 participants
Summary
Replaces hardcoded FontAwesome CDN URL with a configurable environment variable, allowing the CDN endpoint to be changed without modifying source code.
Changes
src/app.html: Replaced hardcoded FontAwesome CDN links with template placeholders (%fontawesome.baseUrl%) for dynamic URL injection.env.example: AddedPUBLIC_FONTAWESOME_CSS_BASE_URLenvironment variable with documentation and default value pointing to the existing CDNsrc/config/public.ts: AddedPUBLIC_FONTAWESOME_CSS_BASE_URLto the public configuration schema with Zod validationsrc/hooks.server.ts: Updated the page chunk transformation to replace the FontAwesome URL placeholder with the configured value at runtime, alongside the existing locale replacementImplementation Details
The FontAwesome CSS base URL is now injected during server-side rendering via the
transformPageChunkhook, ensuring the correct URL is used regardless of the deployment environment. This follows the existing pattern used for locale injection and allows the CDN endpoint to be updated (e.g., if the FontAwesome CDN moves) by simply changing the environment variable without code changes.https://claude.ai/code/session_01T4QrtB6cFFZPx8VnAuiK4F